Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions #308

Merged
merged 15 commits into from
May 21, 2024
Merged

Switch to GitHub Actions #308

merged 15 commits into from
May 21, 2024

Conversation

MattiSG
Copy link
Member

@MattiSG MattiSG commented May 20, 2024 •
edited
Loading

Details in #307.

Fixes #307, #284.

Integrates #286.

If merged:

Proofs that this works, that have to be double-checked:

  • CI can fail when errors are voluntarily introduced on lint and build.
  • Content updates in the openfisca.org repository, on the test-cd branch that was created as a test target branch as a duplicate of gh-pages. All files are changed because of the Sphinx (static website generator) update, but only those under the doc folder, as they should.
  • The dependency graph for CI and CD is valid.
image

@MattiSG MattiSG requested a review from Ndpnt May 20, 2024 21:19
MattiSG added a commit to openfisca/openfisca-core that referenced this pull request May 21, 2024
@MattiSG
Update doc building workflow to latest version
9febd33 
Following openfisca/openfisca-doc#308
@MattiSG
Copy link
Member Author

MattiSG commented May 21, 2024

I tried to update the OpenFisca-Core doc update trigger, but encounter issues with GitHub access tokens.

I followed the Actions documentation on workflow: dispatch, created a fine-grained access token for the Bot, updated the Core workflow, but the trigger fails with the following message:

Resource not accessible by personal access token

Here is the token I created:

image

@MattiSG MattiSG linked an issue May 21, 2024 that may be closed by this pull request
Switch from CircleCI to Github Actions #284
Closed
@MattiSG
Copy link
Member Author

MattiSG commented May 21, 2024

Turns out organisation-level personal access tokens were not enabled on the OpenFisca org, I switched them on and could now create a proper PAT:

Capture d’écran 2024-05-21 à 14 36 50

Using this new token, the error is now:

curl -L \
    -X POST \
    -H "Accept: application/vnd.github+json" \
    -H "Authorization: Bearer github_pat_XXXXXXXXXXX" \
    -H "X-GitHub-Api-Version: 2022-11-28" \
    https://api.github.com/repos/openfisca/openfisca-doc/actions/workflows/deploy/dispatches \
    -d '{"ref":"cd"}'

→

{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest/actions/workflows#create-a-workflow-dispatch-event"
}

@MattiSG
Copy link
Member Author

MattiSG commented May 21, 2024

I got the trigger to run from a Core commit!!

The workflow_id parameter turned out not to be deploy, but the filename of the workflow, i.e. deploy.yaml.

MattiSG added a commit to openfisca/openfisca-core that referenced this pull request May 21, 2024
@MattiSG
Update doc building workflow to latest version
001a610 
Following openfisca/openfisca-doc#308
@MattiSG MattiSG requested a review from Ndpnt May 21, 2024 13:13
@MattiSG
Copy link
Member Author

MattiSG commented May 21, 2024

Thanks a lot for your reviews @Ndpnt! Shipping this now 🤘

MattiSG and others added 15 commits May 21, 2024 15:46
@MattiSG
Add deploy workflow in GitHub Actions
ce6ec3a
@martinez-hugo @MattiSG
Add GitHub Actions workflow
9179e78
@MattiSG
Adapt and update test GitHub Actions workflow
28dcd92
@MattiSG
Split GitHub Actions workflows
7430acb 
Set up dependencies
@MattiSG
Use long options
b0f5550 
Increase readability
@MattiSG
Remove CircleCI support
b504a54
@MattiSG
Set CI / CD triggers to production mode
4869d39
@MattiSG @Ndpnt
Remove redundant dependency
40a06b7 
Co-authored-by: Nicolas Dupont <nicolas.dupont@beta.gouv.fr>
@MattiSG @Ndpnt
Make jobs names more explicit
907d748 
Rename Test workflow to Validate as linting is not exactly a test
Rename Build job to include critical caching part

Co-authored-by: Nicolas Dupont <nicolas.dupont@beta.gouv.fr>
@MattiSG @Ndpnt
Reorder workflow
16dd3e1 
Make external dependencies more explicit on top

Co-authored-by: Nicolas Dupont <nicolas.dupont@beta.gouv.fr>
@MattiSG @Ndpnt
Set author for CD deployments
3cc06ee 
Co-authored-by: Nicolas Dupont <nicolas.dupont@beta.gouv.fr>
@MattiSG
Set commit message for CD deployments
14b400f
@MattiSG @Ndpnt
Improve comment
ae6ae20 
Co-authored-by: Nicolas Dupont <nicolas.dupont@beta.gouv.fr>
@MattiSG
Enable doc to be built deployed from Core
4bd89d7
@MattiSG
Unify whitespace
c5f83b8
@MattiSG MattiSG merged commit 1dbb5ab into master May 21, 2024
3 of 4 checks passed
@MattiSG MattiSG deleted the cd-gh-actions branch May 21, 2024 15:57
@MattiSG MattiSG mentioned this pull request May 21, 2024
Closed
MattiSG added a commit to openfisca/openfisca-core that referenced this pull request May 21, 2024
@MattiSG
Update doc building workflow to latest version
77d1869 
Following openfisca/openfisca-doc#308
@MattiSG MattiSG mentioned this pull request May 21, 2024
Merged
2 tasks
@MattiSG
Copy link
Member Author

MattiSG commented May 22, 2024

Deploy trigger updated in openfisca/openfisca-core#1211, all done! ✅

MattiSG added a commit to openfisca/openfisca.org that referenced this pull request May 22, 2024
@MattiSG
Update doc publishing process
737385d 
The documentation now publishes directly to the `gh-pages` branch
See <openfisca/openfisca-doc#308>
MattiSG added a commit to openfisca/openfisca.org that referenced this pull request May 22, 2024
@MattiSG
Update doc publishing process
f836d35 
The documentation now publishes directly to the `gh-pages` branch
See <openfisca/openfisca-doc#308>
@MattiSG MattiSG mentioned this pull request May 22, 2024
Merged
2 tasks
MattiSG added a commit to openfisca/openfisca-ops that referenced this pull request May 22, 2024
@MattiSG
Update Doc and website deployment documentation
91b4d79 
Follows openfisca/openfisca-doc#308
@MattiSG MattiSG mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndpnt Ndpnt Ndpnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continuous deployment is broken Switch from CircleCI to Github Actions
3 participants
@MattiSG @Ndpnt @martinez-hugo